On Tue, Nov 20, 2018 at 09:15:31PM +0900, Kunihiko Hayashi wrote: [...] > > > +static int uniphier_pcie_link_up(struct dw_pcie *pci) > > > > This function returns a bool value, make it return a bool. > > This function is registered in struct dw_pcie_ops.link_up, that is defined > in pcie-designware.h as follows: > > int (*link_up)(struct dw_pcie *pcie); > > Changing the return type of this function makes type mismatch, > so I think it's difficult to change it. You are right, it is fine. Thanks, Lorenzo
