Hello, On Thu, 22 Nov 2018 15:45:23 +0100, Thomas Petazzoni wrote: > This should be: > > if (!IS_ERR(pcie->reset_gpio)) > > Indeed, in the case of an error, pcie->reset_gpio will be non-NULL, > with the error encoded as a ERR_PTR(). Meh, scrap that. If pcie->reset_gpio was an error, probe() has failed. So by the time we are in armada8k_pcie_host_init(), pcie->reset_gpio is either NULL or a valid GPIO. So my comment was stupid. Since the newline thing is way too minor to require a new iteration: Acked-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx> Thanks, and sorry for the noise. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
