Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Heiner Kallweit <hkallweit1@xxxxxxxxx>
Date: Sun, 11 Nov 2018 11:50:08 +0100

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 69f0abe1b..1fac231fe 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2359,6 +2359,10 @@
>  
>  #define PCI_VENDOR_ID_SYNOPSYS		0x16c3
>  
> +#define PCI_VENDOR_ID_USR		0x16ec
> +#define PCI_DEVICE_ID_USR_997902	0x0116
> +#define PCI_DEVICE_ID_USR_6692		0x3409
> +
>  #define PCI_VENDOR_ID_VITESSE		0x1725
>  #define PCI_DEVICE_ID_VITESSE_VSC7174	0x7174

Generally, as I understand the policy for linux/pci_ids.h, we only add
things used in multiple locations.

So PCI_VENDOR_ID_USR is OK, since it is used in both r8169 and w6692.

But the device IDs are not, since only w6692 uses them.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux