On 10/31/2018 5:06 PM, Lorenzo Pieralisi wrote: > On Wed, Oct 31, 2018 at 12:17:50PM +0000, Leonard Crestez wrote: >> On 10/31/2018 8:12 AM, Shawn Guo wrote: >>> On Mon, Oct 08, 2018 at 06:06:23PM +0000, Leonard Crestez wrote: >>>> This was implemented in the driver but not actually defined and >>>> referenced in dts. This makes it always on. >>>> >>>> From reference manual in section "10.4.1.4.1 Power Distribution": >>>> >>>> "Display domain - The DISPLAY domain contains GIS, CSI, PXP, LCDIF, >>>> PCIe, DCIC, and LDB. It is supplied by internal regulator." >>>> >>>> The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is >>>> actually inside the DISPLAY domain. Handle this by adding the pcie node >>>> in both power domains. >>>> >>>> Signed-off-by: Leonard Crestez <leonard.crestez@xxxxxxx> >>> >>> Applied, thanks. >> >> As mentioned in the cover letter this requires multi-PD support in >> imx-pci to be implemented, specifically PATCH 3/4 of this series: >> >> Unless that also gets merged soon via pci I expect issues in linux-next. > > I do not know what you mean by "issues in linux-next" (I assume you mean > when Shawn sends the patches to linux-next in preparation for v4.21); we > have not planned any other PCI pull request for v4.20-rc1 material. Yes my concern is linux-next for 4.21 >> The patch already has reviewed-by tags so "merging it soon" is not >> unreasonable. > > I can ACK it if Shawn wants to pull it, it may take a while to see it > in -next if it has to go through the PCI tree, I think it is better > to queue the series without splitting the patches across multiple > channels though. This sounds great to me, merging the whole series through Shawn's imx tree would prevent issues in linux-next or possible bisect failures in 4.21.