On Wed, Oct 17, 2018 at 1:54 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Wed, Oct 17, 2018 at 8:59 AM Suganath Prabu > <suganath-prabu.subramani@xxxxxxxxxxxx> wrote: > > > > * If EEDPTagMode field in manufacturing page11 is set, > > unset it. This is needed to fix a hardware bug > > in SAS3/SAS2 cards, So, skipping EEDPTagMode changes > > in Manufacturing page11 for SAS35 controllers. > > > > * Fix driver modifying NVRAM/persistent data in > > Manufacturing page11 along with current copy. Driver should > > change only current copy of Manufacturing page11. > > > - if (ioc->manu_pg11.EEDPTagMode == 0) { > > + if ((!ioc->is_gen35_ioc) && (ioc->manu_pg11.EEDPTagMode == 0)) { > > No need to have parens. > Yes, We ll remove parentheses in v6 patch set. Thanks, > > -- > With Best Regards, > Andy Shevchenko