> if (!pdev->p2pdma) > > In other words, I don't understand why we are testing "publish"... > > 682 return; > 683 > 684 pdev->p2pdma->p2pmem_published = publish; > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .. or simplify it even further to: if (pdev->p2pdma) pdev->p2pdma->p2pmem_published = publish;