On Tue, Sep 18, 2018 at 05:58:36PM -0600, Keith Busch wrote: > I ran into a lot of trouble testing error handling, and this series is > just trying to simplify some things. The first 4 fix up aer_inject, and > the rest are cleanup to make better use of kernel APIs. > > Keith Busch (12): > PCI: Set PCI bus accessors to noinline > PCI/AER: Covertly inject errors > PCI/AER: Reuse existing service device lookup > PCI/AER: Abstract AER interrupt handling > PCI/AER: Remove dead code > PCI/AER: Remove error source from aer struct > PCI/AER: Use kfifo for tracking events > PCI/AER: Use kfifo helper inserting locked elements > PCI/AER: Don't read upstream ports below fatal errors > PCI/AER: Use threaded IRQ for bottom half > PCI/AER: Use managed resource allocations > PCI/pciehp: Use device managed allocations > > drivers/pci/access.c | 4 +- > drivers/pci/hotplug/pciehp_core.c | 14 +- > drivers/pci/hotplug/pciehp_hpc.c | 48 ++---- > drivers/pci/pcie/Kconfig | 2 +- > drivers/pci/pcie/aer.c | 219 ++++++--------------------- > drivers/pci/pcie/aer_inject.c | 306 ++++++++++++++++++++------------------ > drivers/pci/pcie/portdrv.h | 4 - > drivers/pci/pcie/portdrv_core.c | 1 + > 8 files changed, 227 insertions(+), 371 deletions(-) Thanks a lot for doing this! I applied these to pci/hotplug for v4.20, except for "PCI/AER: Don't read upstream ports below fatal errors", which seems to be already there via another posting, and "PCI/pciehp: Use device managed allocations", which needs a few tweaks.