On Thu, Oct 04, 2018 at 01:13:42PM +0200, Thomas Petazzoni wrote: > Hello, > > On Thu, 4 Oct 2018 11:48:05 +0100, Lorenzo Pieralisi wrote: > > > > I would drop "recently introduced", unless we can define a precise > > > commit when code was added so that it can actually be checked (I know > > > you can't since the relevant patch is part of this series and not in > > > the mainline yet). > > > > > > Bjorn posted some guidelines that are helpful: > > > > > > https://marc.info/?l=linux-pci&m=150905742808166&w=2 > > > > > > I can make these changes myself, no problem but please address Russell's > > > comment so that we can proceed. > > > > Hi Thomas, > > > > I understand you have more important things to think about these days :) > > (congratulations), let me know if I can fix this patch up myself, I > > would like to merge this series for v4.20. > > Fixing up the commit log, of course, you can fix up yourself. However, > Russell made a comment about a remaining FIXME, and I haven't had the > chance to get back deep into the code to remember why I added this > FIXME, and whether it is still needed or not. Thank you for making my point about unexplained FIXME comments so well! -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
