On Tue, Sep 25, 2018 at 05:07:17PM -0400, Sinan Kaya wrote: > On 9/25/2018 4:45 PM, Bjorn Helgaas wrote: > > > We need a contract between the reset API users and the PCI core about the > > > types of reset that a user needs vs. what PCI core can do internally. > > > If a platform supports hotplug, we need to do hotplug reset as an example. > > > > > > Expose the reset types to the drivers and try different reset types based > > > on the new reset_type parameter. > > > > > > Most users are expected to use PCI_RESET_ANY, PCI_RESET_FUNC or > > > PCI_RESET_LINK parameters. > > I understand the words above, but I don't really understand the > > motivation behind this. Can you help flesh that out a bit? > > > > I guess there's a problem being solved by these patches, and it would > > help a lot to have some details about what it is. > > > > It would be ideal if we could offer some guidance, probably as code > > comments, to help driver writers choose the correct reset type. > > Alex and I discussed this here: > > https://www.spinics.net/lists/linux-pci/msg75828.html Thanks; needs to be distilled and included in the code as comments.
