Re: [pci:pci/hotplug 15/24] bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 21, 2018 at 10:06:44AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/hotplug
> head:   64ab39d38d17e5d53434d949681c3ff3ec0f79d3
> commit: d17964c0d81fc38c733fc5281436d2b262306a33 [15/24] PCI/DPC: Save and restore config state
> config: m68k-m5475evb_defconfig (attached as .config)
> compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d17964c0d81fc38c733fc5281436d2b262306a33
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.2.0 make.cross ARCH=m68k 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/pci/bus.o: In function `pci_save_dpc_state':
> >> bus.c:(.text+0x358): multiple definition of `pci_save_dpc_state'
>    drivers/pci/access.o:access.c:(.text+0x1114): first defined here
>    drivers/pci/bus.o: In function `pci_restore_dpc_state':
> >> bus.c:(.text+0x35a): multiple definition of `pci_restore_dpc_state'

Appropriate fix to be sent:

---
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index a244bd0c5ca7..eb3125decffe 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -402,8 +402,8 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info);
 void pci_save_dpc_state(struct pci_dev *dev);
 void pci_restore_dpc_state(struct pci_dev *dev);
 #else
-void pci_save_dpc_state(struct pci_dev *dev) {}
-void pci_restore_dpc_state(struct pci_dev *dev) {}
+static inline void pci_save_dpc_state(struct pci_dev *dev) {}
+static inline void pci_restore_dpc_state(struct pci_dev *dev) {}
 #endif
 
 #ifdef CONFIG_PCI_ATS
--



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux