On Thu, Sep 20, 2018 at 03:47:36PM -0400, Sinan Kaya wrote: > On 9/20/2018 3:46 PM, Sinan Kaya wrote: > > On 9/20/2018 12:27 PM, Keith Busch wrote: > > > /* > > > * DPC disables the Link automatically in hardware, so it has > > > * already been reset by the time we get here. > > > */ > > > - devdpc = pcie_port_find_device(pdev, PCIE_PORT_SERVICE_DPC); > > > - pciedev = to_pcie_device(devdpc); > > > - dpc = get_service_data(pciedev); > > > + dpc = to_dpc_dev(pdev); > > > > I thought that the struct pci_dev sent here is the bridge and we > > need to locate the struct device of the DPC object here. > > > > Isn't this change wrong now? > > Gosh, I should have looked 30 lines above. Nevermind. Yeah, this part should be equivalent to before. This patch just created the opportunity to move this to a common helper, otherwise it would have been duplicated two more times.
