On Wed, Sep 19, 2018 at 11:11:19AM -0400, Sinan Kaya wrote:
> On 9/18/2018 7:58 PM, Keith Busch wrote:
> > - ctrl->notification_enabled = 1;
> > return 0;
> > }
> > void pcie_shutdown_notification(struct controller *ctrl)
> > {
> > - if (ctrl->notification_enabled) {
> > - pcie_disable_notification(ctrl);
> > - pciehp_free_irq(ctrl);
> > - ctrl->notification_enabled = 0;
> > - }
> > + pcie_disable_notification(ctrl);
> > + if (pciehp_poll_mode)
> > + kthread_stop(ctrl->poll_thread);
> > }
>
> I think this notification_enabled bit change needs to go to
> another path. The rest of the change in this file is pretty mechanic changes.
> Also, are you going to remove the notification_enabled member?
Right, we don't need it, and I should have removed it. There is no path
that would call pcie_shutdown_notification if it hadn't been enabled.
