On Thu, Jul 12, 2018 at 07:30:41AM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@xxxxxxxxx>
>
> drivers/pci/controller/pci-tegra.c:1132:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/")
> CC: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> ---
>
> pci-tegra.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Thierry,
are you OK with this change ? I will remove the Fixes: tag since
this does not fix anything AFAICS.
Lorenzo
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -1129,10 +1129,7 @@ static int tegra_pcie_resets_get(struct
> return PTR_ERR(pcie->afi_rst);
>
> pcie->pcie_xrst = devm_reset_control_get_exclusive(dev, "pcie_x");
> - if (IS_ERR(pcie->pcie_xrst))
> - return PTR_ERR(pcie->pcie_xrst);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(pcie->pcie_xrst);
> }
>
> static int tegra_pcie_phys_get_legacy(struct tegra_pcie *pcie)
