On Wed, Sep 12, 2018 at 05:48:30PM +0200, Thomas Petazzoni wrote: > This commit convers the pci-mvebu driver to use the recently > introduced pci-bridge-emul logic, that helps emulating a root port PCI > bridge configuration space. > > It has been tested on Armada GP XP, with a E1000E NIC. I think this needs commentry explaining the "FIXME": > - case PCISWCAP_EXP_DEVCTL: > + case PCI_EXP_DEVCTL: > *value = mvebu_readl(port, PCIE_CAP_PCIEXP + PCI_EXP_DEVCTL) & > ~(PCI_EXP_DEVCTL_URRE | PCI_EXP_DEVCTL_FERE | > PCI_EXP_DEVCTL_NFERE | PCI_EXP_DEVCTL_CERE); > - *value |= bridge->pcie_devctl; > + /* FIXME */ > + *value |= bridge->pcie_conf.devctl; > break; otherwise it's likely to end up remaining there. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up According to speedtest.net: 13Mbps down 490kbps up
