On 13/09/18 01:34 AM, Wesley.Sheng@xxxxxxxxxxxxx wrote: > From: Wesley Sheng <_Wesley.Sheng@microchip.com_ > <mailto:Wesley.Sheng@xxxxxxxxxxxxx>> Similar to your previous patches, these are mangled by your email client. It also would have also been better to send a small patch series instead of these three individual patches. > reserved for customers to implement up to 6 vendor-specific events, 24 > bytes per event > comments on PAX specific GFMS event Why do we need to merge this? You didn't present any code using these new fields so this seems useless. > Signed-off-by: Wesley Sheng <Wesley.Sheng@xxxxxxxxxxxxx> > --- > include/linux/switchtec.h | 19 ++++++++++++++++--- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/include/linux/switchtec.h b/include/linux/switchtec.h > index ec93e93..e3cb8b8 100644 > --- a/include/linux/switchtec.h > +++ b/include/linux/switchtec.h > @@ -59,6 +59,12 @@ enum mrpc_status { > SWITCHTEC_MRPC_STATUS_INTERRUPTED = 0x100, > }; > > +struct event { > + u32 hdr; > + u32 data[5]; > +}; This doesn't follow the way the other events are doing things, and you didn't convert all the other events, so it just looks inconsistent. Logan
