Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
Date: Wed, 5 Sep 2018 14:18:03 -0600
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Stephen Bates <sbates@xxxxxxxxxxxx>, Keith Busch <keith.busch@xxxxxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxxxx>, Max Gurtovoy <maxg@xxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Jérôme Glisse <jglisse@xxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Christian König <christian.koenig@xxxxxxx>
In-reply-to: <2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>
References: <20180830185352.3369-1-logang@deltatee.com> <20180830185352.3369-8-logang@deltatee.com> <b5ab8fa3-34ac-3117-fa0d-5206c3939435@kernel.dk> <20180901082812.GB670@lst.de> <5f79c012-c6e1-56bb-62fd-0689181fb2c9@deltatee.com> <59b28977-8f2a-6228-2050-03fae6bdbedd@kernel.dk> <1b4283da-44df-4a02-3167-e295243cef78@deltatee.com> <09258b9b-3aed-9890-b31a-bd70a133966c@kernel.dk> <20180905195647.GA1626@lst.de> <bcc1b3cf-2fd9-fa61-9cfb-b0e4d84e5d94@kernel.dk> <20180905201152.GA1893@lst.de> <eb42fb94-9da6-955b-8524-0a0f5ac4bd19@deltatee.com> <2a3394bd-5f13-4818-43f4-dfc61f501e05@kernel.dk>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1


On 05/09/18 02:14 PM, Jens Axboe wrote:
> But if the caller must absolutely know where the bio will end up, then
> it seems super redundant. So I'd vote for killing this check, it buys
> us absolutely nothing and isn't even exhaustive in its current form.


Ok, I'll remove it for v6.

Logan

Follow-Ups:
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe

References:
- [PATCH v5 00/13] Copy Offload in NVMe Fabrics with P2P PCI Memory
  - From: Logan Gunthorpe
- [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Logan Gunthorpe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Christoph Hellwig
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Logan Gunthorpe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Logan Gunthorpe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Christoph Hellwig
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Christoph Hellwig
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Logan Gunthorpe
- Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
  - From: Jens Axboe

Prev by Date: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
Next by Date: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
Previous by thread: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
Next by thread: Re: [PATCH v5 07/13] block: Add PCI P2P flag for request queue and check support for requests
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]