On Wed, Sep 05, 2018 at 05:20:08PM +0100, Alan Douglas wrote:
> Test the correct value to see whether the PHY get failed.
If you intended a new paragraph here, please insert a blank line.
> Use devm_phy_get() instead of devm_phy_optional_get(), since it is
> only called if phy name is given in devicetree and so should exist.
> If failure when getting or linking PHY, put any PHYs which were
> already got and unlink them.
>
> Fixes: dfb80534692ddc5b ("PCI: cadence: Add generic PHY support to host and EP drivers")
> Signed-off-by: Alan Douglas <adouglas@xxxxxxxxxxx>
Lorenzo will probably take care of this for you, but if you repost this for
any reason, please follow the capitalization convention:
$ git log --oneline --follow drivers/pci/controller/pcie-cadence.c
ee12c9efe685 PCI: cadence: Add Power Management ops for host and EP
dfb80534692d PCI: cadence: Add generic PHY support to host and EP drivers
6e0832fa432e PCI: Collect all native drivers under drivers/pci/controller/
37dddf14f1ae PCI: cadence: Add EndPoint Controller driver for Cadence PCIe controller
> ---
> drivers/pci/controller/pcie-cadence.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-cadence.c b/drivers/pci/controller/pcie-cadence.c
> index 86f1b00..67d2f98 100644
> --- a/drivers/pci/controller/pcie-cadence.c
> +++ b/drivers/pci/controller/pcie-cadence.c
> @@ -190,14 +190,16 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie)
>
> for (i = 0; i < phy_count; i++) {
> of_property_read_string_index(np, "phy-names", i, &name);
> - phy[i] = devm_phy_optional_get(dev, name);
> - if (IS_ERR(phy))
> - return PTR_ERR(phy);
> -
> + phy[i] = devm_phy_get(dev, name);
> + if (IS_ERR(phy[i])) {
> + ret = PTR_ERR(phy[i]);
> + goto err_phy;
> + }
> link[i] = device_link_add(dev, &phy[i]->dev, DL_FLAG_STATELESS);
> if (!link[i]) {
> + devm_phy_put(dev, phy[i]);
> ret = -EINVAL;
> - goto err_link;
> + goto err_phy;
> }
> }
>
> @@ -207,13 +209,15 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie)
>
> ret = cdns_pcie_enable_phy(pcie);
> if (ret)
> - goto err_link;
> + goto err_phy;
>
> return 0;
>
> -err_link:
> +err_phy:
> while (--i >= 0)
> device_link_del(link[i]);
> + while (--i >= 0)
> + devm_phy_put(dev, phy[i]);
>
> return ret;
> }
> --
> 1.9.0
>
