On Tue, 2018-08-28 at 15:55 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 28, 2018 at 01:00:02PM +0000, Leonard Crestez wrote: > > On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > > > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > > > make the system hang after resume when attempting any read from PCI. > > > > > > > > Fix this by adding minimal suspend/resume code from the nxp internal > > > > tree. This will prepare for powering down on suspend and reset the block > > > > on resume. > > > > > > > > Code is only for imx7d but a very similar sequence can be used for > > > > other socs. > > > > > > > > The original author is mostly Richard Zhu <hongxing.zhu@xxxxxxx>, this > > > > patch adjusts the code to the upstream imx7d implemention using reset > > > > controls and power domains. > > > > > > I will add a Suggested-by: replacing this paragraph, it is always better > > > to add proper tags rather than credit hidden in commit logs messages. > > > > Isn't "Originally-by:" a better tag for this? > > We can add that, yes or add Richard as patch author, as you prefer to > give him credit. I think "Originally-by:" is a better fit because there is no clear correspondence with patches from the vendor tree. -- Regards, Leonard