On Fri, Aug 31, 2018 at 03:26:34PM -0600, Keith Busch wrote:
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -174,7 +174,9 @@ static int slot_reset_iter(struct device *device, void *data)
>
> static pci_ers_result_t pcie_portdrv_slot_reset(struct pci_dev *dev)
> {
> + pci_restore_state(dev);
> device_for_each_child(&dev->dev, dev, slot_reset_iter);
> + pci_save_state(dev);
> return PCI_ERS_RESULT_RECOVERED;
> }
Shouldn't this be the other way round, i.e. save, reset, restore?
Also, the function pcie_portdrv_slot_reset() was introduced in the prior
patch, so it seems this is a fix for that other patch and the two should
be squashed together.
Thanks,
Lukas
