On 8/31/2018 10:34 AM, Dennis Dalessandro wrote:
The pci_rest_bus() function calls into pci_probe_reset_slot() to determine whether to call the slot or bus reset. The check has faulty logic in that it does not account for pci_probe_reset_slot() being able to return an errno. Fix by only calling the slot reset when the function returns 0. Treat < 1 and > 1 the same. Cc: Sinan Kaya<okaya@xxxxxxxxxxxxxx> Fixes: 811c5cb37df4 ("PCI: Unify try slot and bus reset API") Reviewed-by: Michael J. Ruhl<michael.j.ruhl@xxxxxxxxx> Signed-off-by: Dennis Dalessandro<dennis.dalessandro@xxxxxxxxx>
Nit. Small typo on the first sentence (pci_rest_bus()). Reviewed-by: Sinan Kaya <okaya@xxxxxxxxxx>