On Thu, 2018-08-30 at 16:02 +0800, Hanjie Lin wrote: > > I thought you said there was only phy on this platform. > > If that's the case, what is this reset shared with ? > > Amlogic axg soc includes two pcie controllers and they share the same pcie phy. > Because of two pcie controllers, meson_pcie_phy_probe() will be called two times. > So, the phy reset must be shared. You are abusing the API then. The phy should have exclusive control of its *own* reset line, not other device should claim this reset. I should then manage the fact that it may have more than one consumer.