On 2018/8/29 8:37, Rob Herring wrote: > On Fri, 24 Aug 2018 15:33:25 +0800, Hanjie Lin wrote: >> From: Yue Wang <yue.wang@xxxxxxxxxxx> >> >> The Meson-PCIE-PHY controller supports the 5-Gbps data rate >> of the PCI Express Gen 2 specification and is backward compatible >> with the 2.5-Gbps Gen 1.1 specification with only >> inferred idle detection supported on Amlogic SoCs. >> >> Signed-off-by: Hanjie Lin <hanjie.lin@xxxxxxxxxxx> >> Signed-off-by: Yue Wang <yue.wang@xxxxxxxxxxx> >> --- >> .../bindings/phy/amlogic,meson-pcie-phy.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-pcie-phy.txt >> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > . > Thanks for the review. As described during the discussion [0], we consider it's too overkill to have a dedicated phy driver which only process reset line. So we will abandon phy driver and integrate phy reset into the controller driver int the next version. [0] https://lkml.kernel.org/r/1535096165-45827-1-git-send-email-hanjie.lin@amlogic.