Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
From: Sinan Kaya <okaya@xxxxxxxxxx>
Date: Wed, 22 Aug 2018 10:51:57 -0400
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, poza@xxxxxxxxxxxxxx, Bjorn Helgaas <helgaas@xxxxxxxxxx>, Thomas Tai <thomas.tai@xxxxxxxxxx>, bhelgaas@xxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-pci-owner@xxxxxxxxxxxxxxx, Sam Bobroff <sam.bobroff@xxxxxxxxxxx>
In-reply-to: <20180822143853.GC19320@localhost.localdomain>
References: <2ecd1fd6d763810d45697f846fa876b58a193b1b.camel@kernel.crashing.org> <20180820155325.GA16148@localhost.localdomain> <cf6de256280be7a2948db6dd2b5bfae92e70e12f.camel@kernel.crashing.org> <6aa71d74-e4dc-c627-1496-981278388bce@kernel.org> <20180820213544.GA16805@localhost.localdomain> <0193e0c5a52d8f2e93958f0683f3acc81cef2bc9.camel@kernel.crashing.org> <fd538f20-0754-f127-ceb9-693fec90b4af@kernel.org> <44195c0d7159ce4cd01b660002b2f5af5d53678b.camel@kernel.crashing.org> <184814fb-0caf-b260-4415-8f96fbdf4831@kernel.org> <20180822091333.rre2okhnrot44dyq@wunner.de> <20180822143853.GC19320@localhost.localdomain>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 8/22/2018 10:38 AM, Keith Busch wrote:

On Wed, Aug 22, 2018 at 11:13:33AM +0200, Lukas Wunner wrote:

On Mon, Aug 20, 2018 at 06:13:03PM -0400, Sinan Kaya wrote:

presence detect is optional


Hm, how so?  Do you have a spec reference for that?


Yeah, presence detect state and change are required if the slot supports
hot plug. If the slot doesn't support these, error handling becomes a
lot simpler.


I double checked the slot capabilities register. You are right, it is
required.

References:
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Benjamin Herrenschmidt
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Keith Busch
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Benjamin Herrenschmidt
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Sinan Kaya
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Keith Busch
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Benjamin Herrenschmidt
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Sinan Kaya
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Benjamin Herrenschmidt
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Sinan Kaya
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Lukas Wunner
- Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
  - From: Keith Busch

Prev by Date: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
Next by Date: Re: [PATCH] r8169: don't use MSI-X on RTL8106e
Previous by thread: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
Next by thread: Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]