Re: [PATCH 1/1] PCI/AER: prevent pcie_do_fatal_recovery from using device after it is removed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-08-20 at 16:13 -0600, Keith Busch wrote:
> 
> There might be some potential here.
> 
> There actualy is a Slot Status Presence Detect State (PDS), but it isn't
> latched. The link and presence change (PDC) are latched.
> 
> A potential problem may be a PDC event handling observes PDS set to the
> last known state if the remove + add happens fast enough, and then no
> action is taken in the current implementation.
> 
> The DPC capability learned from such issues, and they will latch the
> status until acknowledged so those sorts of races are not possible.
> 
> But anyway, maybe we can change pciehp to ignore PDS and always
> re-enumerate when PDC is observed, and that may very well simplify a lot
> of this.

That sounds reasonable to me.

Cheers,
Ben.





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux