On Thu, 2018-08-16 at 13:37 +0530, poza@xxxxxxxxxxxxxx wrote: > > > > In fact looking at pcie_do_nonfatal_recovery() it's indeed completely > > broken. It tells the driver that the slot was reset without actually > > resetting anything... Ugh. > > > > Ben. > > pcie_do_nonfatal_recovery() exhibit the same behavior with or without > the patch-series. > in short, there was no functional change brought in to > pcie_do_nonfatal_recovery() Yes, I know, I'm just saying what it does is broken :-) Keep in mind that those callbacks were designed originally for EEH (which predates AER), and so was the spec written. We don't actually use the AER code on POWER today, so we didn't notice how broken the implementation was :-) We should fix that. Either we can sort all that out by email, or we should plan some kind of catch-up, either at Plumbers (provided I can go there) or maybe a webex call. Cheers, Ben.
