Re: [PATCH v2 0/5] Add MSI-X support for cadence EP driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On August 15, 2018 4:46:21 PM GMT+03:00, Alan Douglas <adouglas@xxxxxxxxxxx> wrote:
>The patch implements MSI-X support in the cadence endpoint driver.
>
>This patch depends on on Gustavo Pimentel's patch series adding MSI-X
>support for EP ("Add MSI-X support on pcitest tool") 
>
>It also adds fixes for MSI issues discovered during testing of MSI-X
>  - Use AXI region 0 for interrupt signalling
>  - Write MSI and MSI-X with 32bit value rather than 16bit
>  - Check for masking before sending MSI or MSI-X
>  - Check link is up before sending IRQ
>
Hi. 
AFAIK the BIOS allocates physical memory for the bars. Assuming that the MSIx bar is only mapped after kernel boots on the endpoint, could it be too late? 

Do we need to trigger re-enumeration of the PCI bus from host side when working with this as an endpoint? 

Thanks, 
Ramon 
>Changes since v1:
>  - Rebased on 4.18-rc1
>  - Update commit log to mark first 4 patches as fixes
>  - Correct formatting issues pointed out by checkpatch --strict
>
>Alan Douglas (5):
>  PCI: cadence: Use AXI region 0 to signal interrupts from EP
>  PCI: cadence: Write MSI data with 32bits
>  PCI: cadence: Check whether MSI is masked before sending it
>  PCI: cadence: Check link is up before sending IRQ from EP
>  PCI: cadence: Add MSI-X capability to EP driver
>
>drivers/pci/controller/pcie-cadence-ep.c | 131
>+++++++++++++++++++++++++++++--
> drivers/pci/controller/pcie-cadence.h    |   1 +
> 2 files changed, 125 insertions(+), 7 deletions(-)


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux