[ ... ]>>>>>>> + if (dev)
+ pci_info(dev, "Device recovery from fatal error
successful\n");
+ else
+ pr_err("AER: Can not find pci_dev for
%04x:%02x:%02x.%x\n",
+ domain, bus,
+ PCI_SLOT(devfn), PCI_FUNC(devfn));
+ pci_dev_put(dev);
That is, replace above with:
pr_info("AER: Device %04x:%02x:%02x.%x recover from fatal error
successful\n", domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
is this not sufficient to print ? which is there already.
pci_info(dev, "Device recovery from fatal error successful\n");
Unfortunately, I can't use "dev" because as you said I can't
pci_get_domain_slot to search for it after rescanning.
-T
If I understood the patch correctly,
1) it is restructuring of pci_dev_put(dev);
2) now we are sending uevent only if it is bridge.
3) the other logic where you store and compare bdf is not required,
although we have to fix following.
pci_info(dev, "Device recovery from fatal error successful\n");
probably 1) and 2) could be a separate patch.
Yes Oza. I will separate 1) and 2) and fix the pci_info(dev, "...") to
use domain:bus:devfn
by the way,
In my testing even after removing device the call pci_uevent_ers(dev,
PCI_ERS_RESULT_DISCONNECT); did not create any problem.
I think that is dangerous, if we restructure pci_dev_put(dev), ie revert
commit bd91b56cb3b27492963caeb5fccefe20a986ca8d. The dev structure is
freed and we shouldn't really use it to send pci_uevent_ers(). Although
pci_uevent_ers() may be smart enough to figure out to avoid crash, we
should only use it when the dev is not removed.
Thanks,
Thomas
} else {
- pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
- pci_info(dev, "Device recovery from fatal error failed\n");
+ if (is_bridge_device)
previously there was no condition.. why is this required now ?
and it was doing on "dev" while you are doing it on "udev"
is that the reason we dont watnt o use dev after it is removed ?
instead do pci_uevent_ers on bridge ?
Yes, that's exactly the reason. I should have written down the reason
in the commit log. Here is the details explanation for the benefit of
others. If the failing device is a bridge device, udev is equal to
dev. So we can use udev in the pci_uevent_ers. But for non bridge
device the device is already removed from the bus and thus can't send
pci_uevent_ers.
Thank you,
Thomas
+ pci_uevent_ers(udev, PCI_ERS_RESULT_DISCONNECT);
+ pr_err("AER: Device %04x:%02x:%02x.%x recovery from
fatal error failed\n",
+ domain, bus, PCI_SLOT(devfn), PCI_FUNC(devfn));
}
- pci_dev_put(dev);
pci_unlock_rescan_remove();
}
Regards,
Oza.
