Re: Problem with 4cec16861a40 ("PCI/ASPM: Convert to use match_string() helper")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-08-02 at 20:13 +0200, Heiner Kallweit wrote:
> I wondered why my system gets warmer than usual and eventually found
> that
> every write to /sys/module/pcie_aspm/parameters/policy returns EINVAL.

Thanks for spotting this!
My bad.

> 
> Reason is mentioned change, using match_string() is wrong when used
> with
> sysfs because sysfs strings have a trailing newline.

Not always, but you are right, it has to be \n-aware.

>  Seems like the patch
> wasn't tested.
> __sysfs_match_string() has to be used instead. I checked and this
> fixes
> the issue. 

Yes, it should be sysfs variant.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux