Re: [PATCH 2/2] PCI: pciehp: Deduplicate presence check on probe & resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 31, 2018 at 11:03:42AM +0300, Mika Westerberg wrote:
> On Sat, Jul 28, 2018 at 07:22:00AM +0200, Lukas Wunner wrote:
> One small nit, see below:
> 
> > +/**
> > + * pciehp_check_presence() - synthesize event if presence has changed
> 
> You should document the argument as well so that the tool that is used
> to process these knows about it:
> 
>   @ctrl: ....

Right, I'll fix that up in a follow-up commit since Bjorn has already
pushed this version.

@Bjorn: I've double-checked all the rebased and newly applied patches
on the pci/hotplug branch, looks good.  Thanks for adding the reference
to the "Link Status Mapped to the LTSSM" table to the commit message,
and thanks to Sinan for pointing that table out.

Superb job everyone, thanks a lot!

Lukas



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux