On Tue, Jul 31, 2018 at 12:30 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > [+cc Thomas, Christoph, LKML] > > On Mon, Jul 30, 2018 at 12:03:42AM +0200, Heiner Kallweit wrote: >> If we have a threaded interrupt with the handler being NULL, then >> request_threaded_irq() -> __setup_irq() will complain and bail out >> if the IRQF_ONESHOT flag isn't set. Therefore check for the handler >> being NULL and set IRQF_ONESHOT in this case. >> >> This change is needed to migrate the mei_me driver to >> pci_alloc_irq_vectors() and pci_request_irq(). >> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > I'd like an ack from Thomas because this requirement about IRQF_ONESHOT > usage isn't mentioned in the request_threaded_irq() function doc or > Documentation/ * IRQF_ONESHOT - Interrupt is not reenabled after the hardirq handler finished. * Used by threaded interrupts which need to keep the * irq line disabled until the threaded handler has been run. -- With Best Regards, Andy Shevchenko
