On Thu, Jul 19, 2018 at 3:52 AM, Sunil Kovvuri <sunil.kovvuri@xxxxxxxxx> wrote: > Hi, > >> +static struct pci_driver pf_stub_driver = { >> + .name = "pci-pf-stub", >> + .id_table = pci_pf_stub_white_list, >> + .probe = pci_pf_stub_probe, >> + .sriov_configure = pci_sriov_configure_simple, >> +}; >> + > > Is there any specific reason for not disabling SRIOV upon driver unload/remove ? > > i.e if a user sets numVFs to a non-zero value and unloads this driver > then we have a > situation where there is no PF driver in kernel but VFs still exist. > > Thanks, > Sunil. I think it was probably just an oversight on my part. Feel free to submit a patch to disable SR-IOV on remove and I will give it a quick review/ack assuming the code itself is fine. Thanks. - Alex