Hi, Christoph, I will send a v2 according to your comments. Thanks. Shunyong. On Tue, 2018-07-17 at 07:03 -0700, Christoph Hellwig wrote: > > > > diff --git a/include/linux/dma-direction.h b/include/linux/dma- > > direction.h > > index 3649a031893a..9d52716e9218 100644 > > --- a/include/linux/dma-direction.h > > +++ b/include/linux/dma-direction.h > > @@ -2,7 +2,7 @@ > > #ifndef _LINUX_DMA_DIRECTION_H > > #define _LINUX_DMA_DIRECTION_H > > /* > > - * These definitions mirror those in pci.h, so they can be used > > + * These definitions mirror those in pci-dma-compat.h, so they can > > be used > > * interchangeably with their PCI_ counterparts. > > */ > I think we can just drop this comment anymore. > > > > > +#define PCI_DMA_BIDIRECTIONAL (DMA_BIDIRECTIONAL) > > +#define PCI_DMA_TODEVICE (DMA_TO_DEVICE) > > +#define PCI_DMA_FROMDEVICE (DMA_FROM_DEVICE) > > +#define PCI_DMA_NONE (DMA_NONE) > No need for the braces.
