On Mon, Jun 11, 2018 at 05:21:03PM -0700, Ray Jui wrote: > Activate PAXC bridge quirk for more PAXC based PCIe root complex with > the following PCIe device ID: > 0xd750, 0xd802, 0xd804 > > Signed-off-by: Ray Jui <ray.jui@xxxxxxxxxxxx> Because this quirk_paxc_bridge() mechanism is already established, Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> BUT, I would push back on quirk_paxc_bridge() if it were new code. I think it would be much better to implement this in the driver's config accessors so lspci would show the correct things and the generic code that deals with pcie_mpss would work unmodified. > --- > drivers/pci/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 2990ad1..47dfea0 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2195,6 +2195,9 @@ static void quirk_paxc_bridge(struct pci_dev *pdev) > } > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge); > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge); > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge); > #endif > > /* Originally in EDAC sources for i82875P: > -- > 2.1.4 >
