答复: [PATCH v7 1/1] PCI: kirin: Add MSI support

["Songxiaowei (Kirin_DRV)" <songxiaowei@xxxxxxxxxxxxx>]

Hi Andy,

Thank you a lot.

Best Regards,
Xiaowei.

> -----邮件原件-----
> 发件人: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
> 发送时间: 2018年7月11日 17:30
> 收件人: Songxiaowei (Kirin_DRV) <songxiaowei@xxxxxxxxxxxxx>
> 抄送: Wangbinghui <wangbinghui@xxxxxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; Linux Kernel
> Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Suzhuangluan
> <suzhuangluan@xxxxxxxxxxxxx>; Kongfei <kongfei@xxxxxxxxxxxxx>; chenyao
> (F) <chenyao11@xxxxxxxxxx>
> 主题: Re: [PATCH v7 1/1] PCI: kirin: Add MSI support
> 
> On Wed, Jul 11, 2018 at 11:09 AM, Xiaowei Song
> <songxiaowei@xxxxxxxxxxxxx> wrote:
> > Add support for MSI
> >
> 
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> 
> > Signed-off-by: Xiaowei Song <songxiaowei@xxxxxxxxxxxxx>
> > Signed-off-by: Yao Chen <chenyao11@xxxxxxxxxx>
> > ---
> >  drivers/pci/dwc/pcie-kirin.c | 28 ++++++++++++++++++++++++++++
> >  1 file changed, 28 insertions(+)
> >
> > diff --git a/drivers/pci/dwc/pcie-kirin.c
> > b/drivers/pci/dwc/pcie-kirin.c index d2970a009eb5..5352e0c3be82
> 100644
> > --- a/drivers/pci/dwc/pcie-kirin.c
> > +++ b/drivers/pci/dwc/pcie-kirin.c
> > @@ -430,6 +430,9 @@ static int kirin_pcie_host_init(struct pcie_port
> > *pp)  {
> >         kirin_pcie_establish_link(pp);
> >
> > +       if (IS_ENABLED(CONFIG_PCI_MSI))
> > +               dw_pcie_msi_init(pp);
> > +
> >         return 0;
> >  }
> >
> > @@ -445,9 +448,34 @@ static const struct dw_pcie_host_ops
> kirin_pcie_host_ops = {
> >         .host_init = kirin_pcie_host_init,  };
> >
> > +static int kirin_pcie_add_msi(struct dw_pcie *pci,
> > +                               struct platform_device *pdev) {
> > +       int irq;
> > +
> > +       if (IS_ENABLED(CONFIG_PCI_MSI)) {
> > +               irq = platform_get_irq(pdev, 0);
> > +               if (irq < 0) {
> > +                       dev_err(&pdev->dev,
> > +                               "failed to get MSI IRQ (%d)\n", irq);
> > +                       return irq;
> > +               }
> > +
> > +               pci->pp.msi_irq = irq;
> > +       }
> > +
> > +       return 0;
> > +}
> > +
> >  static int __init kirin_add_pcie_port(struct dw_pcie *pci,
> >                                       struct platform_device *pdev)
> {
> > +       int ret;
> > +
> > +       ret = kirin_pcie_add_msi(pci, pdev);
> > +       if (ret)
> > +               return ret;
> > +
> >         pci->pp.ops = &kirin_pcie_host_ops;
> >
> >         return dw_pcie_host_init(&pci->pp);
> > --
> > 2.11.GIT
> >
> 
> 
> 
> --
> With Best Regards,
> Andy Shevchenko