On Thu, Jul 05, 2018 at 12:45:39PM +0300, Dan Carpenter wrote:
> IB_WIN_SIZE is larger than INT_MAX so we need to cast it to u64.
>
> Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Untested... Possibly the problem is that there are too many multiplies
> by * 1024.
Hi Subrahmanya,
I always thought that that macro value was questionable, please
can you comment on this ?
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
> index 4d6c20e47bed..cf0aa7cee5b0 100644
> --- a/drivers/pci/controller/pcie-mobiveil.c
> +++ b/drivers/pci/controller/pcie-mobiveil.c
> @@ -107,7 +107,7 @@
> #define CFG_WINDOW_TYPE 0
> #define IO_WINDOW_TYPE 1
> #define MEM_WINDOW_TYPE 2
> -#define IB_WIN_SIZE (256 * 1024 * 1024 * 1024)
> +#define IB_WIN_SIZE ((u64)256 * 1024 * 1024 * 1024)
> #define MAX_PIO_WINDOWS 8
>
> /* Parameters for the waiting for link up routine */
