Re: [PATCH v3 6/9] PCI: designware-plat: Drop unnecessary root_bus_nr setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shawn,

On 01/07/2018 04:54, Shawn Guo wrote:
> Function dw_pcie_host_init() already initializes the root_bus_nr field
> of 'struct pcie_port', so the -1 assignment prior to calling
> dw_pcie_host_init() in platform specific driver is not really needed.
> Drop it.
> 
> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Cc: Joao Pinto <Joao.Pinto@xxxxxxxxxxxx>
> ---
>  drivers/pci/controller/dwc/pcie-designware-plat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pci/controller/dwc/pcie-designware-plat.c
> index 5937fed4c938..6e048c0b67f2 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c
> @@ -118,7 +118,6 @@ static int dw_plat_add_pcie_port(struct dw_plat_pcie *dw_plat_pcie,
>  			return pp->msi_irq;
>  	}
>  
> -	pp->root_bus_nr = -1;
>  	pp->ops = &dw_plat_pcie_host_ops;
>  
>  	ret = dw_pcie_host_init(pp);
> 

Looks good :)
Thanks

Acked-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>

Regards,
Gustavo



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux