Re: [PATCH v2 1/3] PCI: Data corruption happening due to race condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hari,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on v4.18-rc2 next-20180629]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hari-Vyas/PCI-Data-corruption-happening-due-to-race-condition/20180629-203647
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

Note: the linux-review/Hari-Vyas/PCI-Data-corruption-happening-due-to-race-condition/20180629-203647 HEAD 75ee48282af54fe77cb0ac092623577327440033 builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/pci-common.c: In function 'pcibios_setup_bus_devices':
>> arch/powerpc/kernel/pci-common.c:1017:12: error: 'struct pci_dev' has no member named 'is_added'; did you mean 'is_managed'?
      if (dev->is_added)
               ^~~~~~~~
               is_managed

vim +1017 arch/powerpc/kernel/pci-common.c

7846de40 Guenter Roeck          2013-06-10  1005  
37f02195 Yuanquan Chen          2013-04-02  1006  void pcibios_setup_bus_devices(struct pci_bus *bus)
37f02195 Yuanquan Chen          2013-04-02  1007  {
37f02195 Yuanquan Chen          2013-04-02  1008  	struct pci_dev *dev;
37f02195 Yuanquan Chen          2013-04-02  1009  
37f02195 Yuanquan Chen          2013-04-02  1010  	pr_debug("PCI: Fixup bus devices %d (%s)\n",
37f02195 Yuanquan Chen          2013-04-02  1011  		 bus->number, bus->self ? pci_name(bus->self) : "PHB");
37f02195 Yuanquan Chen          2013-04-02  1012  
37f02195 Yuanquan Chen          2013-04-02  1013  	list_for_each_entry(dev, &bus->devices, bus_list) {
37f02195 Yuanquan Chen          2013-04-02  1014  		/* Cardbus can call us to add new devices to a bus, so ignore
37f02195 Yuanquan Chen          2013-04-02  1015  		 * those who are already fully discovered
37f02195 Yuanquan Chen          2013-04-02  1016  		 */
37f02195 Yuanquan Chen          2013-04-02 @1017  		if (dev->is_added)
37f02195 Yuanquan Chen          2013-04-02  1018  			continue;
37f02195 Yuanquan Chen          2013-04-02  1019  
37f02195 Yuanquan Chen          2013-04-02  1020  		pcibios_setup_device(dev);
37f02195 Yuanquan Chen          2013-04-02  1021  	}
7eef440a Benjamin Herrenschmidt 2008-10-27  1022  }
7eef440a Benjamin Herrenschmidt 2008-10-27  1023  

:::::: The code at line 1017 was first introduced by commit
:::::: 37f02195bee9c25ce44e25204f40b7961a6d7c9d powerpc/pci: fix PCI-e devices rescan issue on powerpc platform

:::::: TO: Yuanquan Chen <Yuanquan.Chen@xxxxxxxxxxxxx>
:::::: CC: Michael Ellerman <michael@xxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux