On Wed, Jun 27, 2018 at 4:35 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Wed, Jun 27, 2018 at 10:34:54AM +0800, Pingfan Liu wrote: > > > 1b2a1e63 Pingfan Liu 2018-06-25 243 } > > > 1b2a1e63 Pingfan Liu 2018-06-25 244 } > > > 1b2a1e63 Pingfan Liu 2018-06-25 @245 BUG_ON(!ret); > > > > > > If the list is empty then "ret" can be unitialized. We test a different > > > list "dev->links.suppliers" to see if that's empty. I wrote a bunch of > > > code to make Smatch try to understand about empty lists, but I don't > > > think it works... > > > > > Yes, if list_empty, then the code can not touch ret. But ret is > > useless in this scene. Does it matter? > > > > I'm not sure I understand what you're asking? Of course, it matters? > Oh, I misunderstood your original comment. Yes, you are right. I will fix it in next version, if this code section is still used. Thanks and regards, Pingfan
