On Mon, Jun 18, 2018 at 08:14:29AM -0700, Christoph Hellwig wrote:
> On Sat, Jun 16, 2018 at 10:09:10PM +0200, Lukas Wunner wrote:
> > Ten years ago, commit 58319b802a61 ("PCI: Hotplug core: remove 'name'")
> > dropped the name element from struct hotplug_slot but neglected to
> > update the skeleton driver.
> >
> > That same year, commit f46753c5e354 ("PCI: introduce pci_slot") raised
> > the number of arguments to pci_hp_register() from one to four.
> >
> > Fourteen years ago, historic commit 7ab60fc1b8e7 ("PCI Hotplug skeleton:
> > final cleanups") removed all usages of the retval variable from
> > pcihp_skel_init() but not the variable itself, provoking a compiler
> > warning:
> > https://git.kernel.org/tglx/history/c/7ab60fc1b8e7
> >
> > Fix it and afford compile test coverage to the driver to prevent the
> > same thing from happening again.
> >
> > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> > ---
> > I guess an alternative would be to delete the skeleton driver,
> > considering that noone bothered to fix these bugs for years.
> > If that is preferred I'll be happy to submit a patch.
>
> I think deleting is is the better idea. skeleton drivers have a tendency
> to get out of sync with reality really quickly as you've shown. And that
> assumes they started out correct, which often isn't the case.
I agree, I don't think it really serves a useful purpose any more.
And I hope we don't have any new hotplug drivers coming.
