On 06/12/18 at 05:10pm, Julia Lawall wrote: > This looks wrong. After a list iterator, the index variable points to a > dummy structure. > > julia > > url: https://github.com/0day-ci/linux/commits/Baoquan-He/resource-Use-list_head-to-link-sibling-resource/20180612-113600 > :::::: branch date: 7 hours ago > :::::: commit date: 7 hours ago > > >> kernel/resource.c:265:17-20: ERROR: invalid reference to the index variable of the iterator on line 253 > > # https://github.com/0day-ci/linux/commit/e906f15906750a86913ba2b1f08bad99129d3dfc > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout e906f15906750a86913ba2b1f08bad99129d3dfc > vim +265 kernel/resource.c > > ^1da177e4 Linus Torvalds 2005-04-16 247 > 5eeec0ec9 Yinghai Lu 2009-12-22 248 static void __release_child_resources(struct resource *r) > 5eeec0ec9 Yinghai Lu 2009-12-22 249 { > e906f1590 Baoquan He 2018-06-12 250 struct resource *tmp, *next; > 5eeec0ec9 Yinghai Lu 2009-12-22 251 resource_size_t size; > 5eeec0ec9 Yinghai Lu 2009-12-22 252 > e906f1590 Baoquan He 2018-06-12 @253 list_for_each_entry_safe(tmp, next, &r->child, sibling) { > 5eeec0ec9 Yinghai Lu 2009-12-22 254 tmp->parent = NULL; > e906f1590 Baoquan He 2018-06-12 255 INIT_LIST_HEAD(&tmp->sibling); list_del_init(&tmp->sibling); Thanks, Julia. Here I should use list_del_init(&op->list) to replace INIT_LIST_HEAD(&tmp->sibling). > 5eeec0ec9 Yinghai Lu 2009-12-22 256 __release_child_resources(tmp); > 5eeec0ec9 Yinghai Lu 2009-12-22 257 > 5eeec0ec9 Yinghai Lu 2009-12-22 258 printk(KERN_DEBUG "release child resource %pR\n", tmp); > 5eeec0ec9 Yinghai Lu 2009-12-22 259 /* need to restore size, and keep flags */ > 5eeec0ec9 Yinghai Lu 2009-12-22 260 size = resource_size(tmp); > 5eeec0ec9 Yinghai Lu 2009-12-22 261 tmp->start = 0; > 5eeec0ec9 Yinghai Lu 2009-12-22 262 tmp->end = size - 1; > 5eeec0ec9 Yinghai Lu 2009-12-22 263 } > e906f1590 Baoquan He 2018-06-12 264 > e906f1590 Baoquan He 2018-06-12 @265 INIT_LIST_HEAD(&tmp->child); > 5eeec0ec9 Yinghai Lu 2009-12-22 266 } > 5eeec0ec9 Yinghai Lu 2009-12-22 267 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
