On 05.06.2018 21:27, Florian Fainelli wrote: > On 06/05/2018 12:17 PM, Heiner Kallweit wrote: >> On 05.06.2018 21:11, Bjorn Helgaas wrote: >>> [+cc linux-pci] >>> >>> On Tue, Jun 05, 2018 at 12:28:05PM -0500, Bjorn Helgaas wrote: >>>> On Tue, Jun 05, 2018 at 06:34:09AM +0000, Ryankao wrote: >>>>> Add realtek folk Hau >>>>> >>>>> -----Original Message----- >>>>> From: Kai Heng Feng [mailto:kai.heng.feng@xxxxxxxxxxxxx] >>>>> Sent: Tuesday, June 05, 2018 1:02 PM >>>>> To: jrg.otte@xxxxxxxxx >>>>> Cc: David Miller <davem@xxxxxxxxxxxxx>; Hayes Wang <hayeswang@xxxxxxxxxxx>; hkallweit1@xxxxxxxxx; romieu@xxxxxxxxxxxxx; Linux Netdev List <netdev@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Ryankao <ryankao@xxxxxxxxxxx> >>>>> Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support >>>>> >>>>> Hi Jörg Otte, >>>>> >>>>> Can you give this patch a try? >>>>> >>>>> Since you are the only one that reported ALDPS/ASPM regression, >>>>> >>>>> And I think this patch should solve the issue you had [1]. >>>>> >>>>> Hopefully we don't need to go down the rabbit hole of blacklist/whitelist... >>>>> >>>>> Kai-Heng >>>>> >>>>> [1] https://lkml.org/lkml/2013/1/5/36 >>>> >>>> I have no idea what ALDPS is. It's not mentioned in the PCIe spec, so >>>> presumably it's some Realtek-specific thing. ASPM is a generic PCIe >>>> thing. Changes to these two things should be in separate patches so >>>> they don't get tangled up. >>>> >> ALDPS = Advanced Link Down Power Saving >> And yes, it's a Realtek feature. > > Link as in Ethernet link or PCI(e) link? Sorry too lazy to let me google > that for myself :) > Sorry .. Link here refers to the Ethernet PHY.
