On Fri, Jun 01, 2018 at 04:35:05PM -0500, Bjorn Helgaas wrote:
> On Tue, May 29, 2018 at 07:01:55PM +0300, Mika Westerberg wrote:
> > When a system is using native PCIe hotplug for Thunderbolt it will be
> > only present in the system when there is a device connected. This pretty
> > much follows the BIOS assisted hotplug behaviour.
> > ...
>
> > +static void acpiphp_native_scan_bridge(struct pci_dev *bridge)
> > +{
> > + struct pci_bus *bus = bridge->subordinate;
> > + struct pci_dev *dev;
> > + int max;
> > +
> > + if (!bus)
> > + return;
> > +
> > + max = bus->busn_res.start;
> > + /* Scan already configured non-hotplug bridges */
> > + for_each_pci_bridge(dev, bus) {
> > + if (!dev->is_hotplug_bridge)
>
> Here we test "dev->is_hotplug_bridge" and below we use
> "hotplug_is_native(bus->self)". Is the difference significant, or
> should we use hotplug_is_native() here as well?
>
> If we do need to use is_hotplug_bridge here, maybe a comment about the
> difference would be helpful.
I think here hotplug_is_native() would work as well. The idea is that we need to
avoid scanning bridges that are handled by pciehp (or shpchp).
