On 6/1/2018 2:53 PM, Bjorn Helgaas wrote: >> + pci_info(pdev, "pci 0000:%02x:%02x.%d config space:\n", >> + pdev->bus->number, PCI_SLOT(pdev->devfn), >> + PCI_FUNC(pdev->devfn)); > I'm still missing something -- why go to the trouble of pdev->bus->number, > PCI_SLOT(), etc? Isn't the output going to look like this? > > pci 0000:00:00.0: pci 0000:00:00.0 config space: > > In other words, wouldn't the following be enough? > > pci_info(pdev, "config space:\n"); > You are right. The origin print function was pr_info. We don't need that stuff anymore. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.