On Fri, Jun 1, 2018 at 6:06 PM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: > On 6/1/2018 11:02 AM, Andy Shevchenko wrote: >> On Wed, May 30, 2018 at 7:34 AM, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: >>> Move early dump functionality into common code so that it is available for >>> all archtiectures. No need to carry arch specific reads around as the read >>> hooks are already initialized by the time pci_setup_device() is getting >>> called during scan. >> >>> /* If set, the PCIe ATS capability will not be used. */ >>> static bool pcie_ats_disabled; >>> >>> +bool pci_early_dump; >>> + >> >> I didn't check above these, but maybe a good idea to add one line >> comment what is this about? > > This was discussed here: > > https://www.spinics.net/lists/linux-pci/msg72859.html I understand what is it. What I'm pointing is the variable in the source without any comment. In the context you have in diff previous one has a comment. -- With Best Regards, Andy Shevchenko
