On 5/25/2018 9:33 PM, Marek Vasut wrote:
If the Gen3 PHY fails to power up, the code does not undo the initialization caused by phy_init(). Add the missing failure handling to the rcar_pcie_phy_init_gen3() function. Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> Reported-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx Fixes: 517ca93a7159 ("PCI: rcar: Add R-Car gen3 PHY support")
[...] Oops, it's my sloppy coding again. Sorry about that... MBR, Sergei