On 05/25/2018 12:09 PM, Geert Uytterhoeven wrote: > On Thu, May 24, 2018 at 4:36 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >> If anything fails past phy_init_fn() and the system is a Gen3 with >> a PHY, the PHY will be left on and inited. This is caused by the >> phy_init_fn, which is in fact a pointer to rcar_pcie_phy_init_gen3() >> function, which starts the PHY, yet has no counterpart in the failpath. >> Add that counterpart. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Note that there's another unhandled failure mode: rcar_pcie_phy_init_gen3() > doesn't call phy_exit() if phy_power_on() fails. Should be fixed by subsequent patch, thanks. -- Best regards, Marek Vasut
