> -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx] > Sent: Friday, May 25, 2018 10:01 AM > To: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Sathya Perla <sathya.perla@xxxxxxxxxxxx>; Felix > Manlunas <felix.manlunas@xxxxxxxxxxxxxxxxxx>; > alexander.duyck@xxxxxxxxx; john.fastabend@xxxxxxxxx; Keller, Jacob E > <jacob.e.keller@xxxxxxxxx>; Donald Dutile <ddutile@xxxxxxxxxx>; oss- > drivers@xxxxxxxxxxxxx; Christoph Hellwig <hch@xxxxxxxxxxxxx>; Derek > Chickles <derek.chickles@xxxxxxxxxxxxxxxxxx>; Satanand Burla > <satananda.burla@xxxxxxxxxxxxxxxxxx>; Raghu Vatsavayi > <raghu.vatsavayi@xxxxxxxxxxxxxxxxxx>; Ajit Khaparde > <ajit.khaparde@xxxxxxxxxxxx>; Sriharsha Basavapatna > <sriharsha.basavapatna@xxxxxxxxxxxx>; Somnath Kotur > <somnath.kotur@xxxxxxxxxxxx>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx > Subject: Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0 > > [+cc liquidio, benet, fm10k maintainers: > > The patch below will affect you if your driver calls > pci_sriov_set_totalvfs(dev, 0); > > Previously that caused a subsequent pci_sriov_get_totalvfs() to return > the totalVFs value from the SR-IOV capability. After this patch, it will > return 0, which has implications for VF enablement via the sysfs > "sriov_numvfs" file.] > Thanks. I don't foresee any issues with fm10k regarding this.. Thanks, Jake