On Thu, May 24, 2018 at 01:30:05PM -0500, Bjorn Helgaas wrote: > I applied the following to pci/hotplug for v4.18: > > PCI: pciehp: Clear Presence Detect and Data Link Layer Status Changed on resume > PCI: Request control of native PCIe hotplug only if supported > PCI: Rename host->native_hotplug to host->native_pcie_hotplug > PCI: hotplug: Make pciehp_is_native() stricter > PCI: hotplug: Convert SHPC to be builtin only > PCI: shpchp: Simplify acpi_get_hp_hw_control_from_firmware() > PCI: shpchp: Request control of native SHPC hotplug via _OSC > PCI: Improve "partially hidden behind bridge" log message > ACPI / hotplug / PCI: Drop unnecessary parentheses > > I split a couple of these into smaller pieces and removed one NULL > pointer check, but otherwise they're straightforward. Thanks! > These are the simple pieces that probably don't fix anything by > themselves. I'm looking at the other parts too and have a couple > comments there, but at least we can clear these off the plate. You are right, the patches you applied don't fix anything and are more like "nice to have" material. The critical patches that you did not apply are: PCI: Take all bridges into account when calculating bus numbers for extension ACPI / hotplug / PCI: Do not scan all bridges when native PCIe hotplug is used These two IMHO should be prioritized higher than doing some cleanup for SHPC which pretty much is not used in modern systems anyway. Without the above two patches all systems using native mode will not work properly when you plug in TBT or normal USB-C device.
