On 23 May 2018 19:52, Rob Herring wrote:
> On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote:
> > Update DT documentation to include optional PHYs for cadence PCIe
> > host and endpoint controllers.
> >
> > Signed-off-by: Alan Douglas <adouglas@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-
> ep.txt
> > index 9a305237..e40c635 100644
> > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > @@ -9,6 +9,8 @@ Required properties:
> >
> > Optional properties:
> > - max-functions: Maximum number of functions that can be configured (default 1).
> > +- phys: From PHY bindings: List of Generic PHY phandles.
> > +- phy-names: List of names to identify the PHY.
>
> You need to define how many. I'd assume one, but I guess your example is
> 1 per lane.
>
I can update the description in v3 as follows:
- phys: From PHY bindings: List of Generic PHY phandles. One per lane if more than one in the
list. If only one PHY listed it must manage all lanes.
- phy-names: List of names to identify the PHY, one for each in the list.
> >
> > Example:
> >
> > @@ -19,4 +21,6 @@ pcie@fc000000 {
> > reg-names = "reg", "mem";
> > cdns,max-outbound-regions = <16>;
> > max-functions = /bits/ 8 <8>;
> > + phys = <&ep_phy0 &ep_phy1>;
> > + phy-names = "pcie-lane0","pcie-lane1";
> > };
