On 23/05/18 02:18 PM, dmeyer@xxxxxxxxxx wrote: > +#define PCI_DEVICE_ID_MICROSEMI_PFX24XG3 0x8531 I think Bjorn asked not to add the device IDs to the pci_ids.h and to just use the raw IDs in quirks.h. switchtec.c already uses the raw values. Besides that, it looks good to me. Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>